|
From: | Ludovic Courtès |
Subject: | bug#27284: [PATCH 8/8] DRAFT Add (guix self) and use it when pulling. |
Date: | Fri, 27 Oct 2017 16:49:06 -0700 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hi Maxim, Thanks for reviewing this! I’ve fixed the many typos that you noticed. Apart from that, I’ve also addressed the “parallel world” issue that module reloading creates: the trick is to use ‘eval’ (evil!). Anyway, it seems to do the job. New patches attached! So at this point, I think it needs more testing mostly. To do that, you need to create a branch with those patches, say ‘wip-pull-derivations’, and then from there you can run: ./pre-inst-env guix pull --url=$PWD --branch=wip-pull-derivations Some other comments: Maxim Cournoyer <address@hidden> skribis: >> + (define *core-modules* >> + (scheme-node "guix-core" >> + '((guix) >> + (guix monad-repl) >> + (guix packages) >> + (guix download) >> + (guix discovery) >> + (guix profiles) >> + (guix build-system gnu) >> + (guix build profiles) >> + (guix build gnu-build-system)) > > Sorting the modules list lexicographically would be neat, here and in > various places. If this seems reasonable, perhaps we could have this > stylistic convention in our guidelines? In this case I wanted to have them sorted “logically”, almost topologically, and I prefer it that way. For (gnu packages …) modules, I agree it makes sense to sort alphabetically though, and yes, we could write it down somewhere in the manual. >> + (define (process-directory directory output) >> + (let ((files (find-files directory "\\.scm$")) >> + (prefix (+ 1 (string-length directory)))) >> + ;; Hide compilation warnings. > > Should this be configurable? Hidden warnings don't have much chance to > get addressed :) The idea is that when you type ‘make’ you still get warnings, but you don’t get them when you run ‘guix pull’, as is already the case (on the grounds that ‘make’ is for developers and ‘guix pull’ for users.) Thanks, Ludo’.
0001-union-Parametrize-the-symlink-procedure.patch
Description: Text Data
0002-gexp-directory-union-has-a-quiet-parameter.patch
Description: Text Data
0003-pull-Trim-import-list.patch
Description: Text Data
0004-DRAFT-Add-guix-self-and-use-it-when-pulling.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |