[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#31560: Commit 47a60325c broke tests/pack.scm
From: |
Chris Marusich |
Subject: |
bug#31560: Commit 47a60325c broke tests/pack.scm |
Date: |
Tue, 22 May 2018 23:09:58 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hi,
It seems that tests/pack.scm began to fail at commit
47a60325ca650e8fc1a291c8655b4297f4de8deb. This commit made the
following change in guix/scripts/pack.scm:
--8<---------------cut here---------------start------------->8---
(define symlink->directives
;; Return "populate directives" to make the given symlink and its
;; parent directories.
(match-lambda
((source '-> target)
(let ((target (string-append #$profile "/" target)))
`((directory ,(dirname source))
- (,source -> ,target))))))
+ (,source
+ -> ,(relative-file-name (dirname source) target)))))))
--8<---------------cut here---------------end--------------->8---
It seems this causes the test to fail because it calls
relative-file-name like this in the test:
(relative-file-name "/bin"
"/home/marusich/guix-upgrade-gnucash/test-tmp/store/3j3mrl1sf3bcx4fzlz655mzsp4bir54j-profile/bin/guile")
which evaluates to
"../home/marusich/guix-upgrade-gnucash/test-tmp/store/3j3mrl1sf3bcx4fzlz655mzsp4bir54j-profile/bin/guile"
which is not equal to
"/home/marusich/guix-upgrade-gnucash/test-tmp/store/3j3mrl1sf3bcx4fzlz655mzsp4bir54j-profile/bin/guile"
so the test fails.
What is the purpose of calling relative-file-name here?
--
Chris
signature.asc
Description: PGP signature
- bug#31560: Commit 47a60325c broke tests/pack.scm,
Chris Marusich <=