[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#31560: Commit 47a60325c broke tests/pack.scm
From: |
Ludovic Courtès |
Subject: |
bug#31560: Commit 47a60325c broke tests/pack.scm |
Date: |
Fri, 01 Jun 2018 15:41:46 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hello,
Chris Marusich <address@hidden> skribis:
> I believe the attached patches fix the issue when applied to the master
> branch. The failing test now passes (along with all the other "make
> check" tests). What do you think? If you approve, then I'll commit it
> to the master branch.
I looked some more and the patch would create broken links. I concluded
that the issue was simply that the test needed to be adjusted to expect
a relative symlink instead of an absolute symlink.
I first cherry-picked the fix that Ricardo made in ‘core-updates’ (same
as the one you posted) as commit
44057a461b1fa8102938c4e0f54d7cbc9dd09b03. Then I adjusted the test in
commit ccc951cab3172adfdaf6fd2dfa8f8cdb98358a69.
Let me know if you think something is amiss!
Thank you,
Ludo’.