bug-gzip
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

1.3.7 build failures on NSK


From: Matthew Woehlke
Subject: 1.3.7 build failures on NSK
Date: Fri, 08 Dec 2006 13:26:50 -0600
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.8) Gecko/20061025 Thunderbird/1.5.0.8 Mnenhy/0.7.4.0

zip.c fails because 'timespec' is not defined. For gzip.c, there is a declaration in lib/timespec.h. If I try to add '#include <spt_types.h>' (which has the OS definition of 'timespec') to gzip.h, then gzip.c fails to build due to the lib/timespec.h definition. Therefore, aside from if gnulib should be fixed for NSK in this instance, it seems that zlib.c is missing an include of lib/timespec.h. Fixed by the following patch which looks consistent with gzip.c:

====
--- ../gzip-1.3.7-orig/zip.c    2006-12-08 10:17:25.000000000 -0800
+++ zip.c       2006-12-08 11:16:19.000000000 -0800
@@ -28,6 +28,8 @@
 #include "gzip.h"
 #include "crypt.h"

+#include "stat-time.h"
+
 #ifdef HAVE_UNISTD_H
 #  include <unistd.h>
 #endif
====

Also, what is gzip's C89 policy? I had to install the following patch for C89 compliance (since I don't have a C99 compiler on NSK):

====
--- ../gzip-1.3.7-orig/gzip.c   2006-12-08 10:17:03.000000000 -0800
+++ gzip.c      2006-12-08 10:19:45.000000000 -0800
@@ -1780,11 +1780,11 @@
   int nsigs = sizeof sig / sizeof sig[0];
   int i;

-  exiting_signal = quiet ? SIGPIPE : 0;
-
 #if SA_NOCLDSTOP
   struct sigaction act;

+  exiting_signal = quiet ? SIGPIPE : 0;
+
   sigemptyset (&caught_signals);
   for (i = 0; i < nsigs; i++)
     {
@@ -1805,6 +1805,8 @@
        sigaction (sig[i], &act, NULL);
       }
 #else
+  exiting_signal = quiet ? SIGPIPE : 0;
+
   for (i = 0; i < nsigs; i++)
     if (signal (sig[i], SIG_IGN) != SIG_IGN)
       {
====

--
Matthew
HIPPOS wallow slightly in the MUDDY RIVER
What do you want to do next?
> WALLOW IN MUDDY RIVER
You join HIPPOS.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]