bug-gzip
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: 1.3.7 build failures on NSK


From: Matthew Woehlke
Subject: RE: 1.3.7 build failures on NSK
Date: Mon, 11 Dec 2006 08:19:41 -0800

Paul Eggert wrote:
> Matthew Woehlke writes:
>> --- ../gzip-1.3.7-orig/zip.c    2006-12-08 10:17:25.000000000 -0800
>> +++ zip.c       2006-12-08 11:16:19.000000000 -0800
>> @@ -28,6 +28,8 @@
>>  #include "gzip.h"
>>  #include "crypt.h"
>>
>> +#include "stat-time.h"
>
> Thanks, but surely this is overkill, as zip.c needs timespec.h, not
> everything in stat-time.h.  So I think I'll change zip.c to inclinde
> timespec.h.

Agreed. In fact, I eventually went with timespec.h as well as
stat-time.h needed additional headers that I didn't want to try to fix.
I only used that originally because that is how gzip.c gets timespec.h.

>> Also, what is gzip's C89 policy?
>
> It attempts to conform to C89, but I rely on you to catch inadvertant
> mistakes.  Thanks for reporting it; I'll fix it in a different way.

Ok, thanks; that's fine so long as it compiles. I just went with
something that worked; I know it wasn't the most elegant solution. :-)

-- 
Matthew




reply via email to

[Prev in Thread] Current Thread [Next in Thread]