[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-hurd] [pathc] oskit-mach build fix
From: |
Roland McGrath |
Subject: |
Re: [Bug-hurd] [pathc] oskit-mach build fix |
Date: |
Sun, 17 Sep 2000 03:16:15 -0400 (EDT) |
There are several issues with your patch.
You should not use $(...) in configure scripts or GNU makefiles.
It is not portable. Use `...` instead, and know the quoting issues.
You have not stated what problems you had with the old setting of
OSKIT_LIBDIR, so I am dubious about your complex changes to how that is
done, and your change of the meaning of the variable.
I would never suggest setting LIBRARY_PATH. That is a bizarre
compatibility variable. The setting of CC ought to be sufficient.
Use -L options in the CC setting if that is appropriate.
The -L switches you added in the linking rules should not be required.
If the configure check succeeds, that means the CC setting suffices.