Re: [PATCH] libdiskfs: merge of init-first.c and init-main.c

[Roland McGrath]

> Calling diskfs_init_main is mandatory.  

This is wrong.  diskfs_init_main is a convenience function for diskfs
filesystems that use a store, and can be the bootstrap filesystem.  A
diskfs filesystem not taking a store argument cannot use diskfs_init_main.
Take for example tmpfs.

> diskfs_init_main calls diskfs_init_diskfs itself.  Therefore, having
> diskfs_init_diskfs as a public interface is useless especially with its
> current comment.  Additionally, diskfs_init_main is the only caller of
> diskfs_init_diskfs.

You are mistaken.  If you would like to make the diskfs.h comments more
clear on the situation as it really is, then such changes would be welcome.