[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: hostname again.

From: Thomas Bushnell, BSG
Subject: Re: hostname again.
Date: 31 Jan 2002 01:09:07 -0800
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1

James Morrison <address@hidden> writes:

> -  err = __dir_mkfile (dir, O_WRONLY, 0644, &new);
> +  err = __dir_mkfile (dir, O_CREAT|O_WRITE, 0644, &new);


O_WRITE is surely better than O_WRONLY, but they are equal in fact.

And the implementation of dir-mkfile.c in libdiskfs always turns on
O_READ, O_WRITE, and O_EXEC anyway, regardless of what you asked for.
I'm not sure why it does this (is it really the right Posix

O_CREAT is entirely ignored here.  The flags are used only to
initialize the peropen for the returned port.

So if this fixes anything, I'm entirely mystified why.  I'd rather not
see the change checked in without understanding it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]