bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: oskit driver for i8042 keyboard controller


From: Marcus Brinkmann
Subject: Re: oskit driver for i8042 keyboard controller
Date: Sun, 10 Nov 2002 02:05:20 +0100
User-agent: Mutt/1.4i

On Fri, Nov 08, 2002 at 10:15:51PM -0500, Roland McGrath wrote:
> > Ok, I can try to find out where the references come from.
> 
> Please do.

ds_notify does a dev_port_lookup that acuires a reference.  This reference
is not released.  So when the last user goes away, and the notification is
sent, there is one reference.  Then the refcount is increased to 2 by
dev_port_lookup, and then lowered to 1.  The device is never actually
released.

Now, I added a second device_deallocate to this function.  This makes sure
the device is actually destroyed.  However, this breaks stuff: The minimal
console doesn't seem to work anymore, and the problem that I can not open
the kbd device for readonly once and then for writing the second time still
persists.  So I am not going to check in this change right now.  This requires
more debugging and/or code staring.

Thanks,
Marcus


-- 
`Rhubarb is no Egyptian god.' GNU      http://www.gnu.org    address@hidden
Marcus Brinkmann              The Hurd http://www.gnu.org/software/hurd/
address@hidden
http://www.marcus-brinkmann.de/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]