[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Unionfs, looking up links and translators

From: Thomas Bushnell, BSG
Subject: Re: Unionfs, looking up links and translators
Date: 19 Dec 2002 13:50:58 -0800
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2

Moritz Schulte <address@hidden> writes:

> > It might well be that we have a hole in the interface here.  Blech.
> So... fs interface change - anyone? =)

I think the right fix is to have lookups for "" do all the normal
processing when you open a file.

That is, it should do the translator startup, symlink, and other
special processing indicated at the comment "If this is translated,
start the translater..." in libdiskfs/dir-lookup.c (and, of course,
parallel code in the other implementations of dir-lookup).

This also requires a code audit for all the cases of null lookups (and
null retries, don't forget) to make sure that this is still the Right
Thing.  I suspect it usually doesn't matter; when it does, O_NOTRANS
should be provided.

Essentially this amounts to moving the gotit: label earlier in the
file, and making sure that setup before the goto is still right.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]