bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Bug#196085: Device files are not accepted under the Hurd


From: Ognyan Kulev
Subject: Bug#196085: Device files are not accepted under the Hurd
Date: Wed, 04 Jun 2003 17:03:32 +0300
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3.1) Gecko/20030527 Debian/1.3.1-2

Package: parted
Version: 1.6.5-1
Severity: important
Tags: patch, upstream

Under the Hurd, when device file is passed as an argument to "parted",
Segmentation fault occurs.  More detailed report can be found in
http://mail.gnu.org/archive/html/bug-hurd/2002-10/msg00036.html

The reason is using store_typed_open instead of store_open.  More
information can be found in $HURD/libstore/store.h (or
/include/hurd/store.h).  Basicly, store_typed_open expects something
like "device:hd0", while store_open expects something like "/dev/hd0".
Needless to say, the latter is what everyone would try.  The first style
is equivalent of (MAJOR,MINOR) pair in *nix, and the second style is
equivalent of block device file name.

I forward this bug report to bug-hurd, as I'm not completly sure if this
is the right fix.

Regards
--
Ognyan Kulev <ogi@fmi.uni-sofia.bg>, "\"Programmer\""
7D9F 66E6 68B7 A62B 0FCF  EB04 80BF 3A8C A252 9782

--- parted-1.6.5.orig/libparted/gnu.c
+++ parted-1.6.5/libparted/gnu.c
@@ -235,12 +235,12 @@
        arch_specific->consume = 1;
  
  retry_open:
-       err = store_typed_open (dev->path, 0, NULL, &arch_specific->store);
+       err = store_open (dev->path, 0, NULL, &arch_specific->store);
        if (err) {
                error_t rw_err = err;
  
-               err = store_typed_open (dev->path, STORE_READONLY, NULL,
-                                       &arch_specific->store);
+               err = store_open (dev->path, STORE_READONLY, NULL,
+                                 &arch_specific->store);
                if (err) {
                        if (ped_exception_throw (
                                PED_EXCEPTION_ERROR,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]