bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linux 2.6 PATCH] support for Hurd ext2 format extensions


From: Michael Banck
Subject: Re: [Linux 2.6 PATCH] support for Hurd ext2 format extensions
Date: Wed, 3 Mar 2004 02:03:23 +0100
User-agent: Mutt/1.5.5.1+cvs20040105i

On Mon, Mar 01, 2004 at 05:32:39PM -0800, Roland McGrath wrote:
> Here is a new version of the patch.  Please let me know how it works for you.

(I've uploaded new versions of the kernel-patch and the kernel-image
packages to 'deb http://people.debian.org/~mbanck/xattr-hurd/ ./')

This time, after formatting the partition, extracting my gnu.tar.bz2
with star went fine and I was able to boot into Hurd without any tweaks
(except fixing /etc/fstab, as I extracted on a different box). The
bootup was complete and successful and I was able to do some stuff like
adding a new user or installing a Debian package.

If you'd like to see any further testing, please tell me what I could
do.

> I hope that was a test filesystem like mine was!

Yes. Marcus and Neal already applauded me for my cautiousness *g*

Two small remarks to your patch:

> Index: fs/ext2/Makefile

Why did you drop the Kconfig data?

> Index: fs/ext2/xattr.h
> ===================================================================
> RCS file: /home/roland/redhat/bkcvs/linux-2.5/fs/ext2/xattr.h,v
> retrieving revision 1.8
> diff -b -p -u -r1.8 xattr.h
> --- fs/ext2/xattr.h   13 May 2003 06:12:52 -0000      1.8
> +++ fs/ext2/xattr.h   13 Feb 2004 03:22:36 -0000
[...]
> @@ -135,6 +136,6 @@ exit_ext2_xattr(void)
>  # endif  /* CONFIG_EXT2_FS_XATTR */
>  
>  extern struct ext2_xattr_handler ext2_xattr_user_handler;
> +extern struct ext2_xattr_handler ext2_xattr_hurd_handler;
>  extern struct ext2_xattr_handler ext2_xattr_trusted_handler;
>  extern struct ext2_xattr_handler ext2_xattr_security_handler;
  -
> --- /dev/null 2003-06-05 09:19:08.000000000 -0700
> +++ fs/ext2/xattr_hurd.c      2004-02-28 15:11:57.000000000 -0800
> @@ -0,0 +1,260 @@

I had to add this '-' there, or else 'patch -p0' got confused and
produced this reject:

**************
*** 135,140 ****
  # endif  /* CONFIG_EXT2_FS_XATTR */

  extern struct ext2_xattr_handler ext2_xattr_user_handler;
  extern struct ext2_xattr_handler ext2_xattr_trusted_handler;
  extern struct ext2_xattr_handler ext2_xattr_security_handler;
- -- /dev/null  2003-06-05 09:19:08.000000000 -0700
--- 136,141 ----
  # endif  /* CONFIG_EXT2_FS_XATTR */

  extern struct ext2_xattr_handler ext2_xattr_user_handler;
+ extern struct ext2_xattr_handler ext2_xattr_hurd_handler;
  extern struct ext2_xattr_handler ext2_xattr_trusted_handler;
  extern struct ext2_xattr_handler ext2_xattr_security_handler;


thanks,

Michael

-- 
<neal> you are crazy to even mount them!!!
<marcus> azeem haha :)
<marcus> azeem: You are a mad man




reply via email to

[Prev in Thread] Current Thread [Next in Thread]