|
From: | Barry deFreese |
Subject: | Gnumach clean: Need advice, re Header files |
Date: | Wed, 8 Nov 2006 21:45:13 -0500 |
Hi again,Looking at more of the implicit declarations of functions (and there are a ton). The question now is, where to declare them and/or put the header files. printf.h was a little bit of a special case because it didn't exist. But, take, for example, panic(). It is instantiated in debug.c but used in a ton of .c files. There is a kern/debug.h but it's not even included in many of the files utilizing panic(). Same goes for copyin, copyout, splx, and many, many more.
Samuel, Thomas, and I were discussing it breifly on IRC and thought maybe moving the header files to include/ and changing the source files might make sense. In this case, I would move kern/debug.h, add a declaration for panic(), and move the file to include/debug.h and change all the #includes?
Anyone else have any thoughts on this? Thanks,Barry deFreese (aka bddebian)
[Prev in Thread] | Current Thread | [Next in Thread] |