bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: The patch of glibc which allows the user to override the pfinet serv


From: zhengda
Subject: Re: The patch of glibc which allows the user to override the pfinet server
Date: Tue, 08 Jul 2008 01:15:11 +0200
User-agent: Thunderbird 2.0.0.14 (X11/20080421)

olafBuddenhagen@gmx.net wrote:
Hi,

On Wed, Jul 02, 2008 at 08:42:43PM +0200, zhengda wrote:

The new version of the patch is below.

Hm, what about dropping/replacing the "_PATH" bit, as discussed in the
other subthread?...
OK.
I wonder if I can use __snprintf(). The code in the original glibc
doesn't use it.

I'm not a glibc hacker; but I would be very surprised if it was a
problem...
It works. but I wonder why the original implementation doesn't use it.
because of the performance or something else?
but apparently, the performance isn't very important in this piece of code.
_hurd_socket_server() shouldn't be called often, and there is a cache for different protocol domains.
+     __snprintf (sock_serv_env_name, 30, "SOCK_SERV_%d_PATH", domain);

I'd say use "sizeof sock_serv_env_name", rather than hard-coding 30, for
better robustness...
OK.

The patch is http://www.assembla.com/spaces/VNetHurd/documents/aJidqKp6ur3z-Nab7jnrAJ/download/A%20patch%20of%20glibc
The link is also on wiki.

Best,
Zheng Da




reply via email to

[Prev in Thread] Current Thread [Next in Thread]