Re: [PATCH 1/3] Add the ``--mount'' command line option

[Carl Fredrik Hammar]

Hi,

I skimmed through this patch and noticed some issues with the license.

On Thu, Jun 11, 2009 at 09:10:24PM +0300, Sergiu Ivanov wrote:
> >From d0f0f5c41d9046aec765a7264914c19642adead9 Mon Sep 17 00:00:00 2001
> From: Sergiu Ivanov <unlimitedscolobb@gmail.com>
> Date: Thu, 11 Jun 2009 15:22:24 +0300
> Subject: [PATCH] Add the ``--mount'' command line option.
> 
> +++ b/unionmount.c
> @@ -0,0 +1,28 @@
> +/* Hurd unionmount
> +   The core of unionmount functionality.
> +
> +   Copyright (C) 2009 Free Software Foundation, Inc.
> +
> +   Written by Sergiu Ivanov <unlimitedscolobb@gmail.com>.
> +
> +   This program is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU General Public License version
> +   2 as published by the Free Software Foundation.

This should be:

   This program is free software; you can redistribute it and/or
   modify it under the terms of the GNU General Public License
   as published by the Free Software Foundation; either version 2
   of the License, or (at your option) any later version.

Note the ``or any later version'' part.

> +   You should have received a copy of the GNU General Public License
> +   along with this program; if not, write to the Free Software
> +   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> +   USA.  */

I remember being told that the address has changed when I was working
on libchannel.  And indeed the address is different in my libchannel
source:

   If not, write to the Free Software Foundation, 675 Mass Ave, Cambridge,
   MA 02139, USA.

I think your using the old address but I'm not sure.  Thomas will have
to clarify.  Perhaps there is a definitive source somewhere.

> +++ b/unionmount.h
> @@ -0,0 +1,31 @@
> +/* Hurd unionmount
> +   General information and properties for unionmount/unionfs.
> +
> +   Copyright (C) 2009 Free Software Foundation, Inc.
> +
> +   Written by Sergiu Ivanov <unlimitedscolobb@gmail.com>.
> +
> +   This program is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU General Public License version
> +   2 as published by the Free Software Foundation.
> +
> +   This program is distributed in the hope that it will be useful, but
> +   WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program; if not, write to the Free Software
> +   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> +   USA.  */

Same here.

Regards,
  Fredrik