[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Don't abuse $(prefix) for finding build-time files.
From: |
Sergiu Ivanov |
Subject: |
Re: [PATCH] Don't abuse $(prefix) for finding build-time files. |
Date: |
Fri, 19 Jun 2009 00:21:17 +0300 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hello,
On Wed, Jun 17, 2009 at 12:40:56AM +0200, Thomas Schwinge wrote:
> On Sun, Jun 07, 2009 at 01:30:12PM +0300, Sergiu Ivanov wrote:
> > +# Provide a default prefix if the user hasn't defined one.
> > +ifeq ($(strip $(prefix)),)
> > +prefix=/usr
> > +endif
>
> This ifeq is non-functional: you can always invoke make like ``make
> prefix=/usr'' to override $(prefix) even when the Makefile
> unconditionally defines ``prefix = whatever''.
I see... Thanks for information.
> To finally bring this to an end, I propose the following. Can you please
> confirm that it works for you?
Yes, it works for me.
> +%.sdefsi:
> + echo '#include <hurd/$*.defs>' | \
> + $(CPP) \
> + $(CPPFLAGS) $(MIGSFLAGS) $($*-MIGSFLAGS) -DSERVERPREFIX=S_ \
> + -x c - -o $@
>
Could you please explain what this expression does? Does it somehow
inject the #include statement into the code of fs_notifyServer.c?..
And another question: how does one get such neatly formatted
mail+patch things? Does one use git format-patch alone?
I'll very much appreciate if somebody would answer these questions,
because I feel like there are many gaps in my understanding of some
things and I'm eager to fill the gaps with knowledge :-)
Regards,
scolobb