[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] Add the code for starting up the mountee
From: |
Carl Fredrik Hammar |
Subject: |
Re: [PATCH 2/3] Add the code for starting up the mountee |
Date: |
Fri, 10 Jul 2009 19:10:07 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hi,
On Fri, Jul 10, 2009 at 04:17:23AM +0200, olafBuddenhagen@gmx.net wrote:
> > > > + /*Opens the port on which to set the new translator */
> > > > + error_t
> > > > + open_port
> > > > + (int flags, mach_port_t * underlying,
> > > > + mach_msg_type_name_t * underlying_type, task_t task, void *cookie)
> > >
> > > AFAIK open_port should not be indented, and the parameter list should
> > > start on the same line.
> >
> > I read in the GCS that emacs should be considered as an expert in GCS
> > indentation, and it indents things like this. Which authority should
> > I comply with?
>
> In general, the existing code is the authority. From what I've seen so
> far, this is handled very consistently in all existing Hurd code, and
> unionfs in fact has many examples.
Also most code I've seen in the hurd has the return type on the same line.
The reasoning to have the return type on a seperate line is to get the
function name in column 0 so it can be easily grepped. But that
obviously can't be applied to nested functions.
Regards,
Fredrik
Re: [PATCH 2/3] Start the mountee in a lazy fashion, Sergiu Ivanov, 2009/07/05