bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: preliminary patch for initrd support in Mach


From: olafBuddenhagen
Subject: Re: preliminary patch for initrd support in Mach
Date: Mon, 9 Aug 2010 22:57:32 +0200
User-agent: Mutt/1.5.20 (2009-06-14)

Hi,

On Tue, Aug 03, 2010 at 07:16:25PM -0400, Jeremie Koenig wrote:
> On Sat, Jul 31, 2010 at 04:49:08PM +0200, Samuel Thibault wrote:
> > Jérémie Koenig, le Sat 12 Jun 2010 19:05:20 +0200, a écrit :

> > > @@ -128,7 +129,7 @@
> > >      }
> > >    else
> > >      {
> > > -      int i, losers, maxlen;
> > > +      int i, losers;
> > >  
> > >        /* Initialize boot script variables.  We leak these send rights.  
> > > */
> > >        losers = boot_script_set_variable
> > > @@ -219,23 +220,19 @@
> > >        }
> > >  #endif
> > >  
> > > -      maxlen = 0;
> > >        for (i = 0; i < boot_info.mods_count; ++i)
> > >   {
> > >     int err;
> > >     char *line = (char*)phystokv(bmods[i].string);
> > > -   int len = strlen (line) + 1;
> > > -   if (len > maxlen)
> > > -     maxlen = len;
> > > -   printf ("\rmodule %d: %*s", i, -maxlen, line);
> > > +   printf ("module %d: %s\n", i, line);
> > >     err = boot_script_parse_line (&bmods[i], line);
> > >     if (err)
> > >       {
> > > -       printf ("\n\tERROR: %s", boot_script_error_string (err));
> > > +       printf ("\tERROR: %s\n", boot_script_error_string (err));
> > >         ++losers;
> > >       }
> > >   }
> > > -      printf ("\r%d multiboot modules %*s", i, -maxlen, "");
> > > +      printf ("%d multiboot modules\n", i);
> > >        if (losers)
> > >   panic ("%d of %d boot script commands could not be parsed",
> > >          losers, boot_info.mods_count);
> > 
> > These seem unrelated, right?  I guess they should be submitted and
> > commited upstream separately.
> 
> If I remember correctly they're actually kindof related, because I needed 
> those
> for the ramdisk message to be displayed correctly.

In that case, you should make an extra patch, and make it part of a
patch series, to go before the actual change that depends on it.

-antrik-



reply via email to

[Prev in Thread] Current Thread [Next in Thread]