bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tmpfs status


From: Maksym Planeta
Subject: Re: tmpfs status
Date: Wed, 28 Mar 2012 23:41:57 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)

Thomas Schwinge <address@hidden> writes:

> Hi!
>
> On Wed, 28 Mar 2012 22:40:22 +0300, Maksym Planeta <address@hidden> wrote:
>> Samuel Thibault <address@hidden> writes:
>> 
>> > Thomas Schwinge, le Mon 26 Mar 2012 22:24:55 +0200, a écrit :
>> >> > 1. 
>> >> > http://git.savannah.gnu.org/cgit/hurd/hurd.git/log/?h=mplaneta/tmpfs/master
>> >> >  
>> >> 
>> >> Someone to review the patches...  :-/
>> >
>> > Just a few comments.
>> >
>> >> Fix auto-terminating of tmpfs due to idle.
>> >
>> > Err, really?  I'd rather not see my tmpfs fly away just because I've
>> > left it dormant for some time.
>> 
>> I meant that now it doesn't auto-terminate.
>
> Yes.  But that should be possible to achieve very much simpler: just put
> ``thread_timeout = server_timeout = 0;'' before diskfs_spawn_first_thread
> is called.  (Or am I missing something?)
>

Variables thread_timeout and server_timeout declared in
../libdiskfs/init-first.c and are static. 

>
>> > Thanks for your work, and looking forward your updated patches.
>> > Samuel
>> 
>> How have I make updated patches? Amend old ones, revert them and then
>> make new patches, but already right or just make patches that correct
>> present errors?
>
> I think you should create a new branch, mplaneta/tmpfs/master-v2 (or
> similar), based on the *current* Savannah master branch (which include
> some of your mplaneta/tmpfs/master commits), and git cherry-pick the
> remaining patches, and fix them as needed -- cherry-pick one, fix it up,
> cherry-pick the next, etc.  Does that sound plausible?
>

For me it sounds good. Thank you.

Regards,
Maksym Planeta.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]