bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH,HURD] hurd: compliance fixes for getgroups


From: Pino Toscano
Subject: Re: [PATCH,HURD] hurd: compliance fixes for getgroups
Date: Sat, 28 Apr 2012 13:21:54 +0200
User-agent: KMail/1.13.7 (Linux/3.2.0-2-amd64; KDE/4.7.4; x86_64; ; )

Alle venerdì 27 aprile 2012, Roland McGrath ha scritto:
> > 2012-04-27  Pino Toscano  <address@hidden>
> > 
> >     * sysdeps/mach/hurd/getgroups.c (__getgroups): Return -1 and set
> >     EINVAL for negative `n' or less than `ngids'.
> 
> The norm is to use all caps and no quotes to mention local variable
> names.  You can also drop the (function) when it's the only function
> in the file of the same name.

Ah ok, fixed patch attached.
Where can I read about these two change log style settings (i.e. 
variables as all caps, and no (function) when it's the only one in a 
file)? I don't remember them in the official pages[1], so maybe I missed 
some documentation...

[1] http://www.gnu.org/prep/standards/html_node/Change-Logs.html

> Since I see you already have
> copyright paperwork and you're doing more than just the one change,
> would you like to get set up to commit yourself?

Given also my contributions so far, I guess that I should better need 
review for now, no?

-- 
Pino Toscano

Attachment: hurd_getgroups.diff
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]