[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix stack corruption in ext2fs server
From: |
Richard Braun |
Subject: |
Re: [PATCH] Fix stack corruption in ext2fs server |
Date: |
Wed, 4 Jul 2012 13:14:27 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Wed, Jul 04, 2012 at 07:58:13AM -0300, Samuel Thibault wrote:
> Richard Braun, le Wed 04 Jul 2012 08:22:13 +0200, a écrit :
> > It's also quite a lot of heap too, and every 5 seconds. We should
> > consider increasing the interval between global syncs to reduce the
> > impact of this potentially heavy operation.
>
> It would increase the amount of work you loose on crash. Did you measure
> the CPU use that you get with a typical filesystem, by e.g. touching a
> file every 4 seconds to trigger the sync all the time?
No.
> I guess the real fix would be to be better at knowing which inodes need
> to be recorded, and filter on that.
Yes, hence the comment in my patch, but I leave that as an exercice for
another motivated hacker.
--
Richard Braun
[PATCH] VM cache policy change., Richard Braun, 2012/07/09
Re: [PATCH] VM cache policy change., Thomas Schwinge, 2012/07/16
Re: [PATCH] VM cache policy change., Richard Braun, 2012/07/16
Re: [PATCH] VM cache policy change., Thomas Schwinge, 2012/07/16
Re: [PATCH] VM cache policy change., Samuel Thibault, 2012/07/15