bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnumach: configure: add --with-version-suffix=STRING


From: Pino Toscano
Subject: Re: [PATCH] gnumach: configure: add --with-version-suffix=STRING
Date: Mon, 1 Oct 2012 19:59:35 +0200
User-agent: KMail/1.13.7 (Linux/3.2.0-3-amd64; KDE/4.8.4; x86_64; ; )

Hi,

Alle giovedì 27 settembre 2012, Thomas Schwinge ha scritto:
> On Mon, 24 Sep 2012 02:04:05 +0200, Guillem Jover 
<address@hidden> wrote:
> > On Mon, 2012-09-24 at 00:30:39 +0200, Pino Toscano wrote:
> > > Alle lunedì 24 settembre 2012, Thomas Schwinge ha scritto:
> > > > On Mon, 24 Sep 2012 00:04:20 +0200, Pino Toscano wrote:
> > > > > +# An optional suffix for the version string.
> > > > > +AC_MSG_CHECKING([for the suffix for the version string])
> > > > > +AC_ARG_WITH(version-suffix,
> > > > > AC_HELP_STRING([--with-version-suffix=STRING], +
> > > > > [append STRING to the version string]),
> > > > > +            [PACKAGE_VERSION_SUFFIX=$withval])
> > > > > +AC_MSG_RESULT([$PACKAGE_VERSION_SUFFIX])
> > > > > +AC_SUBST([PACKAGE_VERSION_SUFFIX])
> > > > 
> > > > Does the AC_MSG_CHECKING and AC_MSG_RESULT add any useful
> > > > information to the build log?  (You should know which option
> > > > you're configuring with.)
> > 
> > Maybe use AC_MSG_NOTICE instead?
> > 
> > > IMHO it makes the log sligtly more useful, since that option
> > > somehow modifies gnumach so it could be useful to know which
> > > options affected its build; also a log could be provided by
> > > other people, so the more information about its build it
> > > provides, the better.
> > 
> > Yeah, I agree.
> 
> I'm not aware of configure scripts typically doing that?  I'd suggest
> to drop that entirely, but don't insist on that.

Ok, I've decided to drop that for now.

> > > > Is --with-version-suffix the standard name for this option?
> > > 
> > > No idea, to be honest :)
> > 
> > I don't think there's any such standard name for this.
> 
> Right, probably not too wide-spread.  GCC has:
> 
>       --with-pkgversion=PKG   Use PKG in the version string in place
> of "GCC"
> 
> Without setting that:
> 
>     i686-pc-gnu-gcc (GCC) 4.7.0 20110905 (experimental)
> 
> With setting it:
> 
>     gcc (Debian 4.7.1-7) 4.7.1
> 
> (Search for case-insensitive pkgversion in config/acx.m4,
> gcc/Makefile.in, gcc/toplev.c, gcc/version.c.)  Would that seem
> reasonable for GNU Mach, too?

It is not the same thing, --with-pkgversion replaces only the part 
inside the brackets, but it does not affect the actual version.

I updated the patch as said above.

-- 
Pino Toscano

Attachment: 0001-configure-add-with-version-suffix-STRING.patch
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]