[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] device: cleanup of the TTY io

From: Marin Ramesa
Subject: Re: [PATCH] device: cleanup of the TTY io
Date: Sun, 08 Sep 2013 19:35:37 +0200

On 08.09.2013 18:53:02, Justus Winter wrote:
> Hi Marin :)
> I think it is awesome of you to start cleaning up gnumach, this is
> much overdue. But you shouldn't mash so many changes into one patch,
> rather split it up. By the way, gnumach uses git and using git it is
> very easy to keep separate changes in your local working branch in
> separate commits. You can then massage them into shape over time and
> when you are done there's this nice git send-email command to send 
> all your patches to the list. This way they are easier to review and 
> to merge upstream.
> Justus

Hi Justus,

I liked the cleanup project idea, it gives me a chance to learn gnumach 
code while at the same time doing some hopefully useful stuff. But as 
you might have guessed this is all new to me so I don't have in 
perspective what is the best way to do stuff and how to make things 
easier for Samuel and others who maintain gnumach. So thanks for the 
valuable advice and feedback, I will have it in mind when I work on the 
next patch. 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]