[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [COMMIT PATCH] [Hurd/gnu-nat] Fix old "signal-thread" command regres

From: Thomas Schwinge
Subject: Re: [COMMIT PATCH] [Hurd/gnu-nat] Fix old "signal-thread" command regression.
Date: Thu, 19 Sep 2013 10:46:27 +0200
User-agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/23.4.1 (i486-pc-linux-gnu)

Hi Pedro!

On Wed, 18 Sep 2013 13:01:39 +0100, Pedro Alves <address@hidden> wrote:
> By inspection, I noticed that when I made the gnu-nat use
> ptid(pid,0,tid) to represent a thread, instead of using ptid(tid,0,0),
> in <https://sourceware.org/ml/gdb-patches/2008-08/msg00175.html>, I
> introduced a bug.
> The change was: [...]

> So before, [...]
> The right fix is to compare the whole ptid to minus_one_ptid, of
> course.
> Completely untested, but I think it's obvious enough, so I went ahead
> and put it in.

Thanks!  Now confirmed the issue as well as the fix.

As I found some months ago, Hurd GDB's signal-thread detection is broken
anyway, but despite that, GDB does work -- will have to look into that.


Attachment: pgpnFA0xw_gXK.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]