[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/14] proc: fix error handling in S_proc_exception_raise
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 09/14] proc: fix error handling in S_proc_exception_raise |
Date: |
Sat, 9 Nov 2013 19:13:35 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Fri 08 Nov 2013 21:24:17 +0100, a écrit :
> Found using the Clang Static Analyzer.
>
> * proc/mgt.c (S_proc_exception_raise): Fix error propagation.
Ack.
> ---
> proc/mgt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/proc/mgt.c b/proc/mgt.c
> index 4da2216..ad6355d 100644
> --- a/proc/mgt.c
> +++ b/proc/mgt.c
> @@ -458,6 +458,8 @@ S_proc_exception_raise (mach_port_t excport,
> ports_port_deref (e);
> mach_port_deallocate (mach_task_self (), thread);
> mach_port_deallocate (mach_task_self (), task);
> + if (err)
> + return err;
> return MIG_NO_REPLY;
>
> default:
> --
> 1.7.10.4
>
>
--
Samuel
<c> ya(ka|ma|to)* ca existe une fois sur 2 au japon, c'est facile ;-)
-+- #ens-mim au japon -+-
- Re: [PATCH 07/14] proc: fix the declaraton of genpid, (continued)
- [PATCH 11/14] auth: fix use of uninitialized variable err, Justus Winter, 2013/11/08
- [PATCH 10/14] init: fix memory leak, Justus Winter, 2013/11/08
- [PATCH 14/14] mach-defpager: remove unused variables, Justus Winter, 2013/11/08
- [PATCH 04/14] proc: turn count_up and store_pid into normal functions, Justus Winter, 2013/11/08
- [PATCH 09/14] proc: fix error handling in S_proc_exception_raise, Justus Winter, 2013/11/08
- Re: [PATCH 09/14] proc: fix error handling in S_proc_exception_raise,
Samuel Thibault <=
- [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions, Justus Winter, 2013/11/08
- Re: [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions, Ludovic Courtès, 2013/11/08
- Re: [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions, Justus Winter, 2013/11/09
- Re: [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions, Richard Braun, 2013/11/09
- Re: [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions, Justus Winter, 2013/11/09
- Re: [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions, Ludovic Courtès, 2013/11/09
- Re: [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions, Samuel Thibault, 2013/11/09
[PATCH 03/14] proc: remove declaration of nested functions from proc.h, Justus Winter, 2013/11/08
[PATCH 05/14] proc: turn reap into a normal function, Justus Winter, 2013/11/08