Re: [PATCH 3/5] kern: eliminate unused assignment

[Samuel Thibault]

Marin Ramesa, le Sun 10 Nov 2013 22:50:22 +0100, a écrit :
> Value of result is never read. Eliminate the unused assignment.
> 
> * kern/elf-load.c: Eliminate unused assignment.

Justus has an ACKed better patch which propagates the result, but I
don't see it applied on the tree, Justus?

> ---
>  kern/elf-load.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kern/elf-load.c b/kern/elf-load.c
> index 1d103d3..c1f4bed 100644
> --- a/kern/elf-load.c
> +++ b/kern/elf-load.c
> @@ -77,9 +77,9 @@ int exec_load(exec_read_func_t *read, exec_read_exec_func_t 
> *read_exec,
>                       if (ph->p_flags & PF_R) type |= EXEC_SECTYPE_READ;
>                       if (ph->p_flags & PF_W) type |= EXEC_SECTYPE_WRITE;
>                       if (ph->p_flags & PF_X) type |= EXEC_SECTYPE_EXECUTE;
> -                     result = (*read_exec)(handle,
> -                                           ph->p_offset, ph->p_filesz,
> -                                           ph->p_vaddr, ph->p_memsz, type);
> +                     (*read_exec)(handle,
> +                             ph->p_offset, ph->p_filesz,
> +                             ph->p_vaddr, ph->p_memsz, type);
>               }
>       }
>  
> -- 
> 1.8.1.4
> 
> 

-- 
Samuel
I develop for Linux for a living, I used to develop for DOS.
Going from DOS to Linux is like trading a glider for an F117.
(By entropy@world.std.com, Lawrence Foard)