bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/11] i386/i386/db_trace.c: return reg value


From: Samuel Thibault
Subject: Re: [PATCH 10/11] i386/i386/db_trace.c: return reg value
Date: Wed, 20 Nov 2013 22:10:54 +0100
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Marin Ramesa, le Wed 20 Nov 2013 20:42:54 +0100, a écrit :
> * i386/i386/db_trace.c (db_i386_reg_value): Return reg value.

I don't see the returned value used anywhere.  I'd say rather drop it
than returning something which is already returned another way.

> ---
>  i386/i386/db_trace.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/i386/i386/db_trace.c b/i386/i386/db_trace.c
> index 419fa0c..71b7620 100644
> --- a/i386/i386/db_trace.c
> +++ b/i386/i386/db_trace.c
> @@ -178,6 +178,7 @@ db_i386_reg_value(
>           *dp = *valuep;
>       else
>           *valuep = *dp;
> +     return *dp;
>  }
>  
>  void
> -- 
> 1.8.1.4
> 
> 

-- 
Samuel
I am the "ILOVEGNU" signature virus. Just copy me to your signature.
This email was infected under the terms of the GNU General Public License.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]