[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/12] libnetfs: fix a dead store
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 04/12] libnetfs: fix a dead store |
Date: |
Wed, 20 Nov 2013 23:51:06 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Wed 20 Nov 2013 14:37:57 +0100, a écrit :
> * libnetfs/fsys-getroot.c (netfs_S_fsys_getroot): Fix dead store.
I'm undecided. Setting err to 0 makes it coherent with the rest, even if
it is not actually used.
> ---
> libnetfs/fsys-getroot.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/libnetfs/fsys-getroot.c b/libnetfs/fsys-getroot.c
> index 0d80111..d3dda17 100644
> --- a/libnetfs/fsys-getroot.c
> +++ b/libnetfs/fsys-getroot.c
> @@ -84,7 +84,6 @@ netfs_S_fsys_getroot (mach_port_t cntl,
> return err;
> }
> /* ENOENT means translator has vanished inside fshelp_fetch_root. */
> - err = 0;
> }
>
> if (type == S_IFLNK && !(flags & (O_NOLINK | O_NOTRANS)))
> --
> 1.7.10.4
>
--
Samuel
<b> j'en ai parlé à xavier, il n'est pas interdit qu'il le change un jour
-+- #sos - a le bras long vers le chameau -+-
- [PATCH 01/12] init: remove unused function run_for_real, Justus Winter, 2013/11/20
- [PATCH 02/12] utils: fix dead initialization, Justus Winter, 2013/11/20
- [PATCH 05/12] fatfs: fix error handling in diskfs_lookup_hard, Justus Winter, 2013/11/20
- [PATCH 04/12] libnetfs: fix a dead store, Justus Winter, 2013/11/20
- Re: [PATCH 04/12] libnetfs: fix a dead store,
Samuel Thibault <=
- [PATCH 03/12] libps: fix the length computation in fprint_frac_value, Justus Winter, 2013/11/20
- [PATCH 06/12] fatfs: fix error handling in diskfs_get_directs, Justus Winter, 2013/11/20
- [PATCH 07/12] ftpfs: fix error handling in refresh_dir, Justus Winter, 2013/11/20
- [PATCH 12/12] libshouldbeinlibc: fix error handling in maptime_map, Justus Winter, 2013/11/20
- [PATCH 09/12] usermux: actually use the computed flags value in netfs_attempt_utimes, Justus Winter, 2013/11/20