[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/12] fatfs: fix error handling in diskfs_lookup_hard
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 05/12] fatfs: fix error handling in diskfs_lookup_hard |
Date: |
Wed, 20 Nov 2013 23:51:45 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Wed 20 Nov 2013 14:37:58 +0100, a écrit :
> Found using the Clang Static Analyzer.
>
> * fatfs/dir.c (diskfs_lookup_hard): Fix error handling.
Ack.
> ---
> fatfs/dir.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fatfs/dir.c b/fatfs/dir.c
> index b2b7d7e..60fc898 100644
> --- a/fatfs/dir.c
> +++ b/fatfs/dir.c
> @@ -231,6 +231,8 @@ diskfs_lookup_hard (struct node *dp, const char *name,
> enum lookup_type type,
> err = vm_map (mach_task_self (),
> &buf, buflen, 0, 1, memobj, 0, 0, prot, prot, 0);
> mach_port_deallocate (mach_task_self (), memobj);
> + if (err)
> + return err;
>
> inum = 0;
>
> --
> 1.7.10.4
>
--
Samuel
> ±z¬O§_¸g±`¬°¦p¦ó©Ý®i¦æ¾PºÞ¹D¶Ë¸£µ¬?
> ¥Zµn³ø¯È,Âø»x¼s§i©Î¶l±H¢Ò¢Û (Direct Mail)¬O§_¤w¸gµLªk¹F¦¨±z¹w´Áªº¼s§i®ÄªG?
Je vous invite a consulter dans un premier temps le french-Howto.
-+- JCD in Guide du linuxien pervers - "Bien configurer la lisibilité de fcolm"
- [PATCH 01/12] init: remove unused function run_for_real, Justus Winter, 2013/11/20
- [PATCH 02/12] utils: fix dead initialization, Justus Winter, 2013/11/20
- [PATCH 05/12] fatfs: fix error handling in diskfs_lookup_hard, Justus Winter, 2013/11/20
- Re: [PATCH 05/12] fatfs: fix error handling in diskfs_lookup_hard,
Samuel Thibault <=
- [PATCH 04/12] libnetfs: fix a dead store, Justus Winter, 2013/11/20
- [PATCH 03/12] libps: fix the length computation in fprint_frac_value, Justus Winter, 2013/11/20
- [PATCH 06/12] fatfs: fix error handling in diskfs_get_directs, Justus Winter, 2013/11/20
- [PATCH 07/12] ftpfs: fix error handling in refresh_dir, Justus Winter, 2013/11/20
- [PATCH 12/12] libshouldbeinlibc: fix error handling in maptime_map, Justus Winter, 2013/11/20