bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/11] libports: improve error handling in ports_reallocate_p


From: Samuel Thibault
Subject: Re: [PATCH 04/11] libports: improve error handling in ports_reallocate_port
Date: Wed, 27 Nov 2013 22:43:57 +0100
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Justus Winter, le Wed 27 Nov 2013 13:31:11 +0100, a écrit :
> * libports/reallocate-port.c (ports_reallocate_port): Improve error
>   handling.

Better safe than sorry, yes. Ack

> ---
>  libports/reallocate-port.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libports/reallocate-port.c b/libports/reallocate-port.c
> index b2977dd..d2adaeb 100644
> --- a/libports/reallocate-port.c
> +++ b/libports/reallocate-port.c
> @@ -48,7 +48,8 @@ ports_reallocate_port (void *portstruct)
>      }
>    pi->cancel_threshold = 0;
>    pi->mscount = 0;
> -  hurd_ihash_add (&pi->bucket->htable, pi->port_right, pi);
> +  err = hurd_ihash_add (&pi->bucket->htable, pi->port_right, pi);
> +  assert_perror (err);
>    pthread_mutex_unlock (&_ports_lock);
>  
>    err = mach_port_move_member (mach_task_self (), pi->port_right, 
> -- 
> 1.7.10.4
> 

-- 
Samuel
Who wants to remember that escape-x-alt-control-left shift-b puts you into
super-edit-debug-compile mode?
(Discussion in comp.os.linux.misc on the intuitiveness of commands, especially
Emacs.)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]