Re: [PATCH 07/11] libdiskfs: improve error reporting in diskfs_start_disk_pager

[Samuel Thibault]

Justus Winter, le Wed 27 Nov 2013 13:31:14 +0100, a écrit :
> * libdiskfs/disk-pager.c (diskfs_start_disk_pager): Improve error reporting.

Better message indeed, ack.

> ---
>  libdiskfs/disk-pager.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libdiskfs/disk-pager.c b/libdiskfs/disk-pager.c
> index 8fe8f80..9a0d9d8 100644
> --- a/libdiskfs/disk-pager.c
> +++ b/libdiskfs/disk-pager.c
> @@ -71,7 +71,8 @@ diskfs_start_disk_pager (struct user_pager_info *upi,
>    diskfs_disk_pager = pager_create (upi, pager_bucket,
>                                   may_cache, MEMORY_OBJECT_COPY_NONE,
>                                   notify_on_evict);
> -  assert (diskfs_disk_pager);
> +  if (diskfs_disk_pager == NULL)
> +    error (2, errno, "creating diskfs_disk_pager failed");
>  
>    /* Get a port to the disk pager.  */
>    disk_pager_port = pager_get_port (diskfs_disk_pager);
> -- 
> 1.7.10.4
> 

-- 
Samuel
        /* Amuse the user. */
        printk(
"              \\|/ ____ \\|/\n"
"              \"@'/ ,. \\`@\"\n"
"              /_| \\__/ |_\\\n"
"                 \\__U_/\n");
(From linux/arch/sparc/kernel/traps.c:die_if_kernel())