[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 5/7] proc: improve the message_demuxer function
From: |
Justus Winter |
Subject: |
[PATCH 5/7] proc: improve the message_demuxer function |
Date: |
Sat, 30 Nov 2013 20:11:01 +0100 |
Handle multiple request types as recommended by the Mach Server
Writer's Guide section 4, subsection "Handling Multiple Request
Types". This avoids initializing the reply message in every X_server
function. The reply message has already been properly initialized in
libports, so there is no need to call mig_reply_setup.
* proc/main.c (message_demuxer): Improve the demuxer function.
---
proc/main.c | 30 ++++++++++++++++++------------
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/proc/main.c b/proc/main.c
index aaaa5a7..5d6dc21 100644
--- a/proc/main.c
+++ b/proc/main.c
@@ -38,18 +38,24 @@ int
message_demuxer (mach_msg_header_t *inp,
mach_msg_header_t *outp)
{
- extern int process_server (mach_msg_header_t *, mach_msg_header_t *);
- extern int notify_server (mach_msg_header_t *, mach_msg_header_t *);
- extern int proc_exc_server (mach_msg_header_t *, mach_msg_header_t *);
- int status;
-
- pthread_mutex_lock (&global_lock);
- status = (process_server (inp, outp)
- || notify_server (inp, outp)
- || ports_interrupt_server (inp, outp)
- || proc_exc_server (inp, outp));
- pthread_mutex_unlock (&global_lock);
- return status;
+ mig_routine_t process_server_routine (mach_msg_header_t *);
+ mig_routine_t notify_server_routine (mach_msg_header_t *);
+ mig_routine_t ports_interrupt_server_routine (mach_msg_header_t *);
+ mig_routine_t proc_exc_server_routine (mach_msg_header_t *);
+
+ mig_routine_t routine;
+ if ((routine = process_server_routine (inp)) ||
+ (routine = notify_server_routine (inp)) ||
+ (routine = ports_interrupt_server_routine (inp)) ||
+ (routine = proc_exc_server_routine (inp)))
+ {
+ pthread_mutex_lock (&global_lock);
+ (*routine) (inp, outp);
+ pthread_mutex_unlock (&global_lock);
+ return TRUE;
+ }
+ else
+ return FALSE;
}
pthread_mutex_t global_lock = PTHREAD_MUTEX_INITIALIZER;
--
1.7.10.4
- Improving the demuxer functions, Justus Winter, 2013/11/29
- [PATCH] libdiskfs: improve the diskfs_demuxer function, Justus Winter, 2013/11/29
- [PATCH 1/7] libdiskfs: improve the diskfs_demuxer function, Justus Winter, 2013/11/30
- [PATCH 3/7] libtrivfs: improve the trivfs_demuxer function, Justus Winter, 2013/11/30
- [PATCH 2/7] libnetfs: improve the netfs_demuxer function, Justus Winter, 2013/11/30
- [PATCH 5/7] proc: improve the message_demuxer function,
Justus Winter <=
- [PATCH 4/7] exec: improve the exec_demuxer function, Justus Winter, 2013/11/30
- [PATCH 6/7] pfinet: improve the pfinet_demuxer function, Justus Winter, 2013/11/30
- [PATCH 7/7] pflocal: improve the demuxer functions, Justus Winter, 2013/11/30