Re: [PATCH 50/66] kern/act.c, act.h: comment unused variable

[Samuel Thibault]

Marin Ramesa, le Thu 05 Dec 2013 22:03:44 +0100, a écrit :
> * kern/act.c (null_act): Comment unused variable.

Well, it is used, by being initialized.  The comment above explains what
it's used for.

> * kern/act.h (null_act): Likewise.
> 
> ---
>  kern/act.c | 2 +-
>  kern/act.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kern/act.c b/kern/act.c
> index 321ff98..61b982e 100644
> --- a/kern/act.c
> +++ b/kern/act.c
> @@ -61,7 +61,7 @@ static Act free_acts[ACT_STATIC_KLUDGE];
>  
>     As you might expect, most of its members have no particular value.
>     alerts is zero.  */
> -Act null_act;
> +/* Act null_act; */
>  
>  void
>  global_act_init()
> diff --git a/kern/act.h b/kern/act.h
> index e064724..cddf6c7 100644
> --- a/kern/act.h
> +++ b/kern/act.h
> @@ -175,7 +175,7 @@ void              act_init(void);
>  kern_return_t        act_terminate_task_locked(struct Act *act);
>  
>  /* Exported to thread.c */
> -extern Act   null_act;
> +/* extern Act        null_act; */
>  kern_return_t        act_create_kernel(Act **out_act);
>  
>  /* Exported to machine-dependent activation code */
> -- 
> 1.8.1.4
> 
> 

-- 
Samuel
There are two types of Linux developers - those who can spell, and
those who can't. There is a constant pitched battle between the two.
(From one of the post-1.1.54 kernel update messages posted to c.o.l.a)