bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 21/28] ddb/db_expr.c (db_mult_expr): remove unnecessary varia


From: Samuel Thibault
Subject: Re: [PATCH 21/28] ddb/db_expr.c (db_mult_expr): remove unnecessary variable
Date: Mon, 9 Dec 2013 00:55:49 +0900
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Marin Ramesa, le Sun 08 Dec 2013 12:40:23 +0100, a écrit :
> Value db_tok_string[0] can be used instead of c.

Ditto.

> * ddb/db_expr.c (db_mult_expr): Remove unnecessary variable.
> 
> ---
>  ddb/db_expr.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/ddb/db_expr.c b/ddb/db_expr.c
> index eee9e4f..bd68f92 100644
> --- a/ddb/db_expr.c
> +++ b/ddb/db_expr.c
> @@ -182,7 +182,6 @@ db_mult_expr(valuep)
>  {
>       db_expr_t       lhs, rhs;
>       int             t;
> -     char            c;
>  
>       if (!db_unary(&lhs))
>           return (FALSE);
> @@ -190,9 +189,8 @@ db_mult_expr(valuep)
>       t = db_read_token();
>       while (t == tSTAR || t == tSLASH || t == tPCT || t == tHASH
>               || t == tBIT_AND) {
> -         c = db_tok_string[0];
>           if (!db_term(&rhs)) {
> -             db_printf("Expression syntax error after '%c'\n", c);
> +             db_printf("Expression syntax error after '%c'\n", 
> db_tok_string[0]);
>               db_error(0);
>               /*NOTREACHED*/
>           }
> -- 
> 1.8.1.4
> 
> 

-- 
Samuel
<macavity> bash: ls: Computer bought the farm
<macavity> THAT frightens ppl! :P
<macavity> id rather see: "bash: ls: Initialization of googol(AWAX)
        disengaged in HYPER32/64 mode due to faulty page request at
        AX:12A34F84B"
<macavity> at least that would give me the feeling that the
        *programmers* knows what is going on :P
(lovely Hurd...)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]