[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/6] kern/lock.h: quiet GCC warnings about set but unused var
|
From: |
Marin Ramesa |
|
Subject: |
Re: [PATCH 2/6] kern/lock.h: quiet GCC warnings about set but unused variables |
|
Date: |
Sun, 15 Dec 2013 20:50:32 +0100 |
On 15.12.2013 20:13:22, Samuel Thibault wrote:
> > index 8fe3672..67067cf 100644
> > --- a/kern/task.c
> > +++ b/kern/task.c
> > @@ -769,7 +769,7 @@ kern_return_t task_info(
> > event_info->cow_faults = task->cow_faults;
> > event_info->messages_sent = task->messages_sent;
> > event_info->messages_received =
> > task->messages_received;
> > - task_unlock(&task);
> > + task_unlock(task);
>
> Err, this is not the same at all, while task_lock is still using
> &task. Either both need the fix, or none.
They both need the fix. This code won't compile when simple_lock() is
an unempty macro or a function.
[PATCH 4/6] ddb/db_break.c (db_delete_cmd): remove unnecessary initialization, Marin Ramesa, 2013/12/12
[PATCH 5/6] ddb/db_expr.c (db_mult_expr): initialize lhs, Marin Ramesa, 2013/12/12
[PATCH 6/6] i386/i386/db_trace.c (db_i386_reg_value): cast to (int *) instead to (long *), Marin Ramesa, 2013/12/12