bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 5/5] ipc: provide the protected payload in ipc_kmsg_copyout_heade


From: Justus Winter
Subject: [PATCH 5/5] ipc: provide the protected payload in ipc_kmsg_copyout_header
Date: Fri, 21 Feb 2014 12:48:53 +0100

* ipc/ipc_kmsg.c (ipc_kmsg_copyout_header): If a protected payload is
  set for the destination port, provide it in msgh_protected_payload.
* doc/mach.texi (Message Receive): Document message semantics with
protected payloads.
---
 doc/mach.texi  | 19 +++++++++++++++++++
 ipc/ipc_kmsg.c | 58 +++++++++++++++++++++++++++++++++++++++++++++-------------
 2 files changed, 64 insertions(+), 13 deletions(-)

diff --git a/doc/mach.texi b/doc/mach.texi
index d61ee22..6167b4b 100644
--- a/doc/mach.texi
+++ b/doc/mach.texi
@@ -1949,6 +1949,25 @@ loses the receive right after the message was dequeued 
from it, then
 right still exists, but isn't held by the caller, then
 @code{msgh_local_port} specifies @code{MACH_PORT_NULL}.
 
+Servers usually associate some state with a receive right.  To that
+end, they might use a hash table to look up the state for the port a
+message was sent to.  To optimize this, a task may associate an opaque
+@var{payload} with a receive right using the
+@code{mach_port_set_protected_payload} function.  Once this is done,
+the kernel will set the @code{msgh_protected_payload} field to
+@var{payload} when delivering a message to this right and indicate
+this by setting the local part of @code{msgh_bits} to
+@code{MACH_MSG_TYPE_PROTECTED_PAYLOAD}.
+
+The support for protected payloads was added to GNU Mach.  To preserve
+binary compatibility, the @code{msgh_local_port} and
+@code{msgh_local_port} share the same location.  This makes it
+possible to add the payload information without increasing the size of
+@code{mach_msg_header_t}.  This is an implementation detail.  Which
+field is valid is determined by the local part of the
+@code{msgh_bits}.  Existing software is not affected.  When a receive
+right is transferred to another task, its payload is cleared.
+
 Received messages are stamped with a sequence number, taken from the
 port from which the message was received.  (Messages received from a
 port set are stamped with a sequence number from the appropriate member
diff --git a/ipc/ipc_kmsg.c b/ipc/ipc_kmsg.c
index 0e43410..7708e42 100644
--- a/ipc/ipc_kmsg.c
+++ b/ipc/ipc_kmsg.c
@@ -1802,9 +1802,17 @@ ipc_kmsg_copyout_header(msg, space, notify)
                } else
                        ip_unlock(dest);
 
-               msg->msgh_bits = (MACH_MSGH_BITS_OTHER(mbits) |
-                                 MACH_MSGH_BITS(0, MACH_MSG_TYPE_PORT_SEND));
-               msg->msgh_local_port = dest_name;
+               if (! dest->ip_has_protected_payload) {
+                       msg->msgh_bits = (MACH_MSGH_BITS_OTHER(mbits) |
+                               MACH_MSGH_BITS(0, MACH_MSG_TYPE_PORT_SEND));
+                       msg->msgh_local_port = dest_name;
+               } else {
+                       msg->msgh_bits = (MACH_MSGH_BITS_OTHER(mbits) |
+                               MACH_MSGH_BITS(
+                                       0, MACH_MSG_TYPE_PROTECTED_PAYLOAD));
+                       msg->msgh_protected_payload =
+                               dest->ip_protected_payload;
+               }
                msg->msgh_remote_port = MACH_PORT_NULL;
                return MACH_MSG_SUCCESS;
            }
@@ -1900,10 +1908,18 @@ ipc_kmsg_copyout_header(msg, space, notify)
                } else
                        ip_unlock(dest);
 
-               msg->msgh_bits = (MACH_MSGH_BITS_OTHER(mbits) |
-                                 MACH_MSGH_BITS(MACH_MSG_TYPE_PORT_SEND_ONCE,
-                                                MACH_MSG_TYPE_PORT_SEND));
-               msg->msgh_local_port = dest_name;
+               if (! dest->ip_has_protected_payload) {
+                       msg->msgh_bits = (MACH_MSGH_BITS_OTHER(mbits) |
+                               MACH_MSGH_BITS(MACH_MSG_TYPE_PORT_SEND_ONCE,
+                                              MACH_MSG_TYPE_PORT_SEND));
+                       msg->msgh_local_port = dest_name;
+               } else {
+                       msg->msgh_bits = (MACH_MSGH_BITS_OTHER(mbits) |
+                               MACH_MSGH_BITS(MACH_MSG_TYPE_PORT_SEND_ONCE,
+                                       MACH_MSG_TYPE_PROTECTED_PAYLOAD));
+                       msg->msgh_protected_payload =
+                               dest->ip_protected_payload;
+               }
                msg->msgh_remote_port = reply_name;
                return MACH_MSG_SUCCESS;
            }
@@ -1935,9 +1951,18 @@ ipc_kmsg_copyout_header(msg, space, notify)
                        dest_name = MACH_PORT_NULL;
                }
 
-               msg->msgh_bits = (MACH_MSGH_BITS_OTHER(mbits) |
-                       MACH_MSGH_BITS(0, MACH_MSG_TYPE_PORT_SEND_ONCE));
-               msg->msgh_local_port = dest_name;
+               if (! dest->ip_has_protected_payload) {
+                       msg->msgh_bits = (MACH_MSGH_BITS_OTHER(mbits) |
+                               MACH_MSGH_BITS(0,
+                                       MACH_MSG_TYPE_PORT_SEND_ONCE));
+                       msg->msgh_local_port = dest_name;
+               } else {
+                       msg->msgh_bits = (MACH_MSGH_BITS_OTHER(mbits) |
+                               MACH_MSGH_BITS(0,
+                                       MACH_MSG_TYPE_PROTECTED_PAYLOAD));
+                       msg->msgh_protected_payload =
+                               dest->ip_protected_payload;
+               }
                msg->msgh_remote_port = MACH_PORT_NULL;
                return MACH_MSG_SUCCESS;
            }
@@ -2227,9 +2252,16 @@ ipc_kmsg_copyout_header(msg, space, notify)
        if (IP_VALID(reply))
                ipc_port_release(reply);
 
-       msg->msgh_bits = (MACH_MSGH_BITS_OTHER(mbits) |
-                         MACH_MSGH_BITS(reply_type, dest_type));
-       msg->msgh_local_port = dest_name;
+       if (! dest->ip_has_protected_payload) {
+               msg->msgh_bits = (MACH_MSGH_BITS_OTHER(mbits) |
+                                 MACH_MSGH_BITS(reply_type, dest_type));
+               msg->msgh_local_port = dest_name;
+       } else {
+               msg->msgh_bits = (MACH_MSGH_BITS_OTHER(mbits) |
+                                 MACH_MSGH_BITS(reply_type,
+                                       MACH_MSG_TYPE_PROTECTED_PAYLOAD));
+               msg->msgh_protected_payload = dest->ip_protected_payload;
+       }
        msg->msgh_remote_port = reply_name;
     }
 
-- 
1.8.5.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]