Re: [PATCH 10/11] ext2fs: improve {enable,disable}_caching

[Samuel Thibault]

Justus Winter, le Mon 12 May 2014 12:05:48 +0200, a écrit :
> * ext2fs/pager.c (enable_caching, disable_caching): Iterate over the
> pager class instead of over both pager buckets.

Mmm, did you check the actual implementation of ports_class_iterate?
It seems that it just iterates over one bucket, the buck of the last
created port of the class.

> diff --git a/ext2fs/pager.c b/ext2fs/pager.c
> index 017efcc..6328f3b 100644
> --- a/ext2fs/pager.c
> +++ b/ext2fs/pager.c
> @@ -1409,8 +1409,7 @@ disable_caching ()
>  
>    /* Loop through the pagers and turn off caching one by one,
>       synchronously.  That should cause termination of each pager. */
> -  ports_bucket_iterate (disk_pager_bucket, block_cache);
> -  ports_bucket_iterate (file_pager_bucket, block_cache);
> +  ports_class_iterate (_pager_class, block_cache);
>  }
>  
>  static void
> @@ -1438,8 +1437,7 @@ enable_caching ()
>        return 0;
>      }
>  
> -  ports_bucket_iterate (disk_pager_bucket, enable_cache);
> -  ports_bucket_iterate (file_pager_bucket, enable_cache);
> +  ports_class_iterate (_pager_class, enable_cache);
>  }
>  
>  /* Tell diskfs if there are pagers exported, and if none, then
> -- 
> 2.0.0.rc0
> 

-- 
Samuel
<b> lisons de l'assembleur c
 -+- #sos - CrisC forever -+-