[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH hurd-dde 5/7] libmachdev: avoid malloc overhead when sending
From: |
Samuel Thibault |
Subject: |
Re: [PATCH hurd-dde 5/7] libmachdev: avoid malloc overhead when sending package |
Date: |
Wed, 26 Nov 2014 18:49:40 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Wed 26 Nov 2014 15:22:34 +0100, a écrit :
> * libmachdev/net.c (netif_rx_handle): Allocate message buffer on the
> stack.
Mmm, why not simply making it a struct net_rcv_msg variable?
> ---
> libmachdev/net.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/libmachdev/net.c b/libmachdev/net.c
> index 5a5cd5d..7ddf95d 100644
> --- a/libmachdev/net.c
> +++ b/libmachdev/net.c
> @@ -232,9 +232,7 @@ netif_rx_handle (char *data, int len, struct net_device
> *dev)
> assert (nd);
>
> /* Allocate a kernel message buffer. */
> - net_msg = malloc (sizeof (*net_msg));
> - if (!net_msg)
> - return;
> + net_msg = alloca (sizeof *net_msg);
>
> pack_size = len - sizeof (struct ethhdr);
> /* remember message sizes must be rounded up */
> @@ -259,7 +257,6 @@ netif_rx_handle (char *data, int len, struct net_device
> *dev)
> net_msg->packet_type = packet_type;
> net_msg->net_rcv_msg_packet_count = ph->length;
> deliver_msg (net_msg, &nd->ifnet.port_list);
> - free (net_msg);
> }
>
> /* Mach device interface routines. */
> --
> 2.1.3
>
--
Samuel
<b> il faut combien de chevaux pour tirer une doloréan à 88 morph ?
***b vient de remarque que 88 mph c'est 142 km/h
<y> aaaaah
<y> c'est pour ça qu'ils limitent à 130 km/h sur les autoroutes
<y> c'est pour éviter que les gens voyagent dans le temps
<b> probablement
- [PATCH hurd-dde 1/7] Drop superfluous files, Justus Winter, 2014/11/26
- [PATCH hurd-dde 6/7] libmachdev: fix size of `net_rcv_msg' message, Justus Winter, 2014/11/26
- [PATCH hurd-dde 7/7] libmachdev: drop static libmachdev.so hack, Justus Winter, 2014/11/26
- [PATCH hurd-dde 3/7] libmachdev: drop unused function, Justus Winter, 2014/11/26
- [PATCH hurd-dde 4/7] libmachdev: drop debugging printf, Justus Winter, 2014/11/26