bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH gnumach 1/2] kern: provide notifications about new tasks


From: Justus Winter
Subject: Re: [PATCH gnumach 1/2] kern: provide notifications about new tasks
Date: Mon, 08 Dec 2014 13:55:18 +0100
User-agent: alot/0.3.5

Quoting Samuel Thibault (2014-11-21 01:50:15)
> Justus Winter, le Wed 12 Nov 2014 16:49:08 +0100, a écrit :
> > +kern_return_t
> > +register_new_task_notification(
> > +     const host_t host,
> > +     ipc_port_t notification)
> > +{
> > +     if (host == HOST_NULL)
> > +             return KERN_INVALID_HOST;
> > +
> > +     if (new_task_notification != NULL)
> > +             return KERN_NO_ACCESS;
> > +
> > +     new_task_notification = notification;
> > +     return KERN_SUCCESS;
> > +}
> 
> Mmm, doesn't this need some additional reference on the notification
> port?  Of course, proc is not supposed to die, but better be safe than
> sorry :)

Hum, please clarify.  I thought the message carries a reference that
we can keep?  There is no destructor function for host_priv_t.

Justus



reply via email to

[Prev in Thread] Current Thread [Next in Thread]