bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Change file_utimes RPC to use a struct timespec and update t


From: Samuel Thibault
Subject: Re: [PATCH] Change file_utimes RPC to use a struct timespec and update the servers to use UTIME_NOW and UTIME_OMIT.
Date: Sat, 19 Sep 2015 15:16:12 +0200
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Flávio Cruz, le Thu 17 Sep 2015 02:05:33 +0000, a écrit :
>    CHANGE_NODE_FIELD (cred,
>                  ({
>                    if (!(err = fshelp_isowner (&np->dn_stat, cred->user)))
>                      {
> -                      if (atime.microseconds == -1)
> +                      if (atime.tv_nsec == UTIME_NOW)
>                          np->dn_set_atime = 1;
> +       else if (atime.tv_nsec == UTIME_OMIT)
> +         ; /* do nothing */

Please take care of the existing indentation, here the code is using
tabs, so please use tabs.  Otherwise it looks very odd when using a
different tabset (here you apparently assumed it to be 2, but other
people may be using something else).

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]