Re: [PATCH] fix compiler warnings in hurd/console-client

[Flavio Cruz]

On Tue, Dec 29, 2015 at 08:43:24PM +0100, Samuel Thibault wrote:
> Flavio Cruz, on Tue 29 Dec 2015 17:35:00 +0100, wrote:
> > @@ -663,10 +663,11 @@ update_leds (void)
> >     | (led_state.num_lock ? 2 : 0)
> >     | (led_state.caps_lock ? 4 : 0);
> >        
> > -      err = device_write_inband (kbd_dev, 0, -1, (void *) leds, 2, 
> > &data_cnt);
> > +      err = device_write_inband (kbd_dev, 0, -1, (void *) leds, 2,
> > +                                 (int *) &data_cnt);
> >        if (!err && data_cnt == 1)
> >     err = device_write_inband (kbd_dev, 0, -1, (void *) &leds[1], 1,
> > -                              &data_cnt);
> > +                              (int *) &data_cnt);
> >      }
> >  }
> >  
> 
> I'm surprised: if the device_write_inband RPC really wants an int*, why
> not making data_cnt an int?

That works better. Thanks.


console-client: Fix compiler warning.

* console-client/pc-kbd.c (update_leds): Replace mach_msg_type_number_t with
int.

diff --git a/console-client/pc-kbd.c b/console-client/pc-kbd.c
index 6f2d827..2fc7608 100644
--- a/console-client/pc-kbd.c
+++ b/console-client/pc-kbd.c
@@ -656,7 +656,7 @@ update_leds (void)
   else
     {
       char leds[2];
-      mach_msg_type_number_t data_cnt = 2;
+      int data_cnt = 2;
 
       leds[0] = '\xed';
       leds[1] = (led_state.scroll_lock ? 1 : 0)