bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Small patch for libicmp/icmp_cksum.c


From: michael
Subject: Re: Small patch for libicmp/icmp_cksum.c
Date: 4 Dec 2002 20:54:50 -0000

> * This won't have the same effect as the original code on a big-endian
>   system.

Could you point out what exactly I broke?

> * For consistency, it would be better to use the u_short typedef
>   instead of unsigned short.
> * You mistyped the variable name as w instead of wp, which shows that
>   you didn't even try to compile this code, let alone test it.

I played with the original function in BSD ping, then wondered what
GNU ping uses and found the same function.  At least it looked the
same to me, so I sent the patch as a suggestion to get rid of two
(in my eyes) unneccesary variable assignments.

Michael




reply via email to

[Prev in Thread] Current Thread [Next in Thread]