Re: [bug-inetutils] Re: ftp: command processing

[Alfred M. Szmidt]

Please post the ChangeLog entry outside the patch in the future.

        * ftp/cmds.c (another): Changed to 'int another (int *pargc,
        char ***pargv, const char *prompt)'. Added new variables
        BUFFER and ARG. Use readline for input. Use add_history only
        when HAVE_LIBREADLINE is defined. Fix error-checking.

See below.  Please use two spaces after a end-of-sentence period as
well.

        * ftp/extern.h (another) [notdef]: Changed to 'int another
        *(int pargc, char ***pargv, const char *prompt)'.

It is simpler, and more clear to simply state `changed type of FOO to
const char *FOO' or some such.

        * ftp/ftp.c (login): Removed HAVE_LIBREADLINE.

        * ftp/ftp_var.h: Removed HAVE_LIBREADLINE and LINE is always char*.

Why?  Is readline included in gnulib?  If readline is included in
gnulib, how does it work together with libhistory that is seperate?

        * ftp/main.c: #include <readline.h> (cmdscanner): Use readline
        uniformly. Use add_history only when HAVE_LIBREADLINE is
        defined. Replaced 0 with NULL.

add_history is only used if HAVE_LIBHISTORY is defined.  If you intend
to use something from gnulib, you should use "readline.h".