[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-librejs] Supporting <link rel="jslicense">
From: |
Loic J. Duros |
Subject: |
Re: [Bug-librejs] Supporting <link rel="jslicense"> |
Date: |
Sat, 22 Feb 2014 10:41:17 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
Patch applied. Thank you!
Loic
Sebastian Noack <address@hidden> writes:
> Hi,
>
> a lot of websites (including https://www.eff.org/) hide the web labels link
> anyway with CSS. So why don't let people use a link-tag as an alternative to
> an a-tag to specify their web labels page, in case they don't want have a
> visible link? We can't force them to show the link anyway, but hiding it with
> CSS looks like a hack, since that is what the link-tag is for. You find the
> patch in the attachment.
>
> Cheers
> Sebastian
>
>
> diff -Naur
> /tmp/librejs-5.4.1.old/lib/html_script_finder/web_labels/js_web_labels.js
> /tmp/librejs-5.4.1.new/lib/html_script_finder/web_labels/js_web_labels.js
> --- /tmp/librejs-5.4.1.old/lib/html_script_finder/web_labels/js_web_labels.js
> 2013-10-26 00:35:13.000000000 +0200
> +++ /tmp/librejs-5.4.1.new/lib/html_script_finder/web_labels/js_web_labels.js
> 2014-02-04 22:43:58.723030048 +0100
> @@ -86,7 +86,7 @@
>
> searchForJsLink: function () {
> //console.log('triggered searchForJsLink');
> - var linkTags = this.dom.getElementsByTagName('a'),
> + var linkTags = this.dom.querySelectorAll('a,link'),
> i = 0,
> len = linkTags.length,
> path;