Re: [Bug-librejs] Making changes to the Savannah repo

[zach wick]

Hello,

In order gain authenticated access to the Git repository on Savannah, you must first create an account and join the LibreJS group [0] as a member.

Once you've done that, you'll be able to add a git remote to your local git repo by doing:

git remote add upstream username@git.sv.gnu.org:/srv/git/librejs.git

Then, you can interact with that repository by doing things like:

git checkout -b upstream webext

git checkout -b my_feature_branch

git add *

git commit

git push upstream my_feature_branch

The above commands will make a local branch that tracks the "webext" branch on Savannah, creates a new feature branch off of that local webext branch, and then adds, commits, and pushes changes to a remote instance of "my_feature_branch" on Savannah, which can then be reviewed and merged into the "webext" branch.

If you run into issues doing this, please let me know and I'll help get you sorted out.

I would prefer that we not use Github at all in LibreJS development as Github can only function if you run their proprietary JS. If we were going to consider making a mirror of Savannah anywhere, I would vote for Gitlab. However, as LibreJS is part of the GNU project, I think that the expectation is that Savannah is the canonical forge for its development.

Good luck and happy hacking!

-zach

[0] https://savannah.gnu.org/projects/librejs/

On Thu, Aug 3, 2017 at 8:29 PM, Nathan Nichols <address@hidden> wrote:

On 08/03/2017 05:30 PM, Nathan Nichols wrote:
> So you are saying I should submit changes to here and just attach the
> changed source files?

Nathan -
regarding the bug tracker - yes - but not to post entire files - what
you would need to do is create a patch file using `git diff` like:
git diff upstream/master your-branch > todays.patch
then attach the todays.patch file to an issue on the bug tracker -
ideally the same issue you already have open about this feature and not
a new issue every day
personally, i would still put my fork on another server and link to it
in on tracker issue for the benefit of anyone who finds this workflow insane
---
Thomas -
yes i understand the libreJS project is bound by these tools that GNU
provides - to get around this limitation the libreJS project would need
to start accepting contributions on another git host - this is more a
criticism of savannah and not the libreJS project but you guys should
realize that the savannah infrastructure itself is a hinderance to all
projects it hosts with respect to weloming newcomers without neck-beards
as for a feature request for better git workflow support - im quite sure
that this is common knowlegde - there has been discussion for several
years about upgrading savannah to the modern fusionforge or re-writing
altogether but this has not happened - i would hope that the savannah
maintainers are already aware that the current system is discouraging
new contributors by not supporting the modern workflow that they grew up
with
this thread as case in point that the new contributor probably has never
heard of a .patch file - that does not mean he is not a competant
programmer - it only means that the "patches via mailing lists" workflow
is very outdated

i can only assume that there is either not the will to modernize or
there is lack of resources to do it - in either case, a feature would
add nothing to the situation

I submitted the patch as an attachment in a bug report.

Thanks for the help

On Thu, Aug 3, 2017 at 4:30 PM, Nathan Nichols <address@hidden> wrote:

Savannah has a BTS, filling a bug report (on project, not Savannah) and attach
a patch is the standard way.
nongnu simply follows GNU projects way : having maintainers. Note you can
enlist several keys on project.
Note also Project Savannah has itself a mailing list and probably relies on BTS
where you can fill feature requests. Main keys to Savannah management are disk
room and bandwidth (almost no fees).

So you are saying I should submit changes to here and just attach the changed source files?

https://savannah.gnu.org/bugs/?func=additem&group=librejs

On Wed, Aug 2, 2017 at 5:48 PM, Nathan Nichols <address@hidden> wrote:

Most of what is up right now in the web-ext branch is already outdated. I would like to submit today's progress.

How do I go about doing this?