Re: [bug-libsigsegv] libsigsegv packaging problem

[Eric Blake]

On 05/03/2011 08:40 AM, Eric Blake wrote:
>> AFAICS the only reason to include windows.h is to get the definition of
>> the CONTEXT type which in turn is used to typedef stackoverflow_context_t.
> 
> This is the second time this issue has come up.  I have previously
> posted patches for the issue, (unfortunately, they predated the public
> list archives at http://lists.gnu.org/archive/html/bug-libsigsegv/), but
> that pre-dated my libsigsegv commit rights and no one else pushed them
> at the time.  I'm re-attaching the patch here; any objection from other
> libsigsegv maintainers on applying it?
> 
>>
>> Is it really necessary to expose this to the application?  Wouldn't it
>> be better to define stackoverflow_context_t to void * for applications?
>> THus we can drop the unfortunate inclusion of windows.h and not clutter
>> the POSIX namespace with Windows definitions.
> 
> That's what I argued when I wrote the patch a year ago April.  Also, my
> patch is available at http://repo.or.cz/w/libsigsegv/ericb.git, if Reini
> would rather rebuild from there instead of the official upstream 2.10.

Seeing as how the pre-built libsigsegv for cygwin is now shipping with
this patch applied, no other platform can be affected by the patch, and
I got no other feedback, I've gone ahead and pushed it.

> 
> commit 316db93844f99a8ed952477b824ab1adea685aee
> Author: Eric Blake <address@hidden>
> Date:   Tue Apr 6 13:51:58 2010 -0600
> 
>     Avoid polluting cygwin namespace.
> 
> diff --git a/ChangeLog b/ChangeLog
> index 82557f7..ae2a15f 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,10 @@
> +2011-05-03  Eric Blake  <address@hidden>
> +
> + Avoid polluting cygwin namespace.
> + * configure.ac (FAULT_CONTEXT_INCLUDE): Avoid including
> + <windows.h> on cygwin.
> + Reported by Corinna Vinschen, via Aharon Robbins.
> +

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature