[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: libtool-1.5.18 -- installed files owned by non-root user

From: Gary V. Vaughan
Subject: Re: FYI: libtool-1.5.18 -- installed files owned by non-root user
Date: Sat, 9 Jul 2005 13:45:39 +0100

Hallo Ralf!

On 9 Jul 2005, at 12:52, Ralf Wildenhues wrote:
* Gary V. Vaughan wrote on Fri, Jul 08, 2005 at 07:27:51PM CEST:
On 8 Jul 2005, at 16:57, Ralf Wildenhues wrote:

--- Makefile.am    2 May 2005 09:20:24 -0000    1.153
+++ Makefile.am    8 Jul 2005 15:54:01 -0000
@@ -254,6 +254,8 @@
    done; \
    ( cd $(srcdir)/m4 && $(AMTAR) chf - $$aclocalfiles; ) \
      | ( umask 0 && cd $(DESTDIR)$(aclocaldir) && $(AMTAR) xf -; )
+    chown -R root $(DESTDIR)$(ltdldatadir) && \
+    chgrp -R root $(DESTDIR)$(ltdldatadir) || :

What about:

    -chown -R root $(DESTDIR)$(ltdldatadir) 2>/dev/null
    -chgrp -R root $(DESTDIR)$(ltdldatadir) 2>/dev/null

Has the problem that you see the chown and the chgrp happening, but
neither do they fail nor do you see the failure.  That would strike
me as odd and misleading, but YMMV.

I would rather see that 'make install' is trying to make the files owned by root, and I think that make's `-' syntax is clearer than `|| :'.

I think you are right about 2>/dev/null being bogus though... if the installer see's it fail, then they might be able to fix it up by hand while they wait for us to address their bug report...

Patch to follow.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]