Re: Issue 854 in lilypond: lilycontrib.tcl

[lilypond]

Comment #10 on issue 854 by percival.music.ca: lilycontrib.tcl
http://code.google.com/p/lilypond/issues/detail?id=854

It's looking quite nice now!  I'm definitely comfortable recommending that  
current
contributors use it, although I have some more usability suggestions.

- Re-order the buttons, and add numbers:
1. Update code
2. Make local commit
3. Make patch set

The last one (abort) shouldn't have any number.  Also, could the background  
or text
color be red?  We should indicate that it's dangerous.


- at a fresh tree, clicking "abort changes" produces an  
empty "aborted_edits" dir.

- at a fresh tree, I added "I AM THE MARSHMELLOW KING!" (don't ask) to the  
top of
ROADMAP.  I then clicked "abort changes".  As expected, my change was lost  
from the
ROADMAP... but it didn't appear in aborted_edits/.  I was hoping that  
clicking "abort
changes" would do "git status", parse the text to find any modified files,  
then dump
those modified files into aborted_edits.

- same deal, MARSHMELLOW KING, but this time I also made a local commit.  I  
verified
that the commit worked with "git status" (on my own command-line).   
Clicked "abort
changes"; still nothing in aborted_edits.


- more of a pie-in-the-sky thing: could the "commit message" be a pop-up  
window, that
only appears when you do "make local commit" ?  Three reasons: first, the  
horizontal
space is wasted unless somebody _is_ making a commit (it'll do nothing but  
confuse
people).  Second, it's appropriate to steal the focus with a new window when
somebody's making a local commit.  Third, the single line doesn't allow  
line-breaks,
so there's no way committers will do the "short one line, blank space,  
longer
description" type of commit messages that we want.

If the above is done, then the buttons could be aligned horizontally  
again... and
ideally, put the "abort changes" on the far-right side, while leaving the  
others
left-aligned.  Separating the destructive "abort changes" from the  
non-destructive
other ones would definitely be good.


- I know you said you're not interested, but it would be nice if clicking  
on the
"update code" in a dirty tree message (i.e. "XYZ: needs update") could be  
parsed to
the extent of notifying the user that they need to make a local commit.


Thanks so much for your work on this, Carl!  I'm not necessarily suggesting  
that
/you/ should make the above changes; I'm just keeping all the comments in  
the same
place, in case anybody else wants to play with this.  I might do it myself  
once
2.13.10 is out.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings