Re: abc2ly produces bad output

[Reinhold Kainhofer]

Am Mittwoch, 17. März 2010 19:46:21 schrieb rog peppe:
> Reinhold Kainhofer <reinhold <at> kainhofer.com> writes:
> > Yes, the alternatives are not correctly identified... That's still open.
> 
> i've found the issue and applied a fix that works some of the
> time. the difficulty is that you can have a :| |2 sequence
> which isn't catered for in try_parse_bar()

yes, exactly, that was the main difficulty here...
Still, there is another bug because right now both \alternative commands are 
never closed... 
I suppose that open alternatives should be closed at the end of the whole 
piece in all cases, and also if another repeat follows...

> > > and a slurring ) is misplaced and has an invalid "-" prefixed.
> > 
> > I already have a fix for this here locally (will push to the git server
> > in a while).
> 
> i found a fix for this too. probably the same one.

Just exchange the handling of slurs with closing tuplets in try_parse_note:

    if slur_begin:
        voices_append ('-(' * slur_begin )
    if slur_end:
        voices_append ('-)' *slur_end )
    if parser_state.parsing_tuplet:
        parser_state.parsing_tuplet = parser_state.parsing_tuplet - 1
        if not parser_state.parsing_tuplet:
            voices_append ("}")


Cheers,
Reinhold

-- 
------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org