[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: midi.c: always false check

From: Keith OHara
Subject: Re: midi.c: always false check
Date: Tue, 17 May 2011 04:50:46 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Nicolas Kaiser <nikai <at> nikai.net> writes:
> I noticed an always false check in midi.c.
> 'track_size' is unsigned and can't be negative.

Thanks, Nicolas.
Yes it looks like track_size holds the length of a string so it should be 
unsigned.  The test for negatives is harmless (the compiler probably removes 
it) but this email can be a reminder to clean up next time someone is working
on that section.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]